Use new HTTP GET retry logic in SearchClient. #8732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
May 5, 2025
sigurdm
reviewed
May 5, 2025
sigurdm
reviewed
May 5, 2025
| } | ||
| throw http.ClientException( | ||
| 'Unexpected status code for $uri: ${rs.statusCode}.'); | ||
| throw UnexpectedStatusException(rs.statusCode, uri); |
Contributor
There was a problem hiding this comment.
Perhaps document that the retry function can check for this.
sigurdm
approved these changes
May 5, 2025
Co-authored-by: Sigurd Meldgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the retry utility method with timeout, headers and caller-provided client. However, on a retry, this client is not recreated (whether and how to express this is to be done in a subsequent PR).